ovpn-admin

mali/ovpn-admin

Fork 0

mirror of https://github.com/flant/ovpn-admin.git synced 2026-02-04 09:12:13 -08:00

Author	SHA1	Message	Date
Konstantin Nezhbert	0ffb58cfe9	Merge 5dd44dad7f208f4e4035daacae33ff2bde7d70dc into 0680b4ff05a4e7b385416f3d87b5e0d234de8e7c	2025-01-17 18:12:07 +02:00
Dmitry Shurupov	0680b4ff05	Merge pull request #293 from ogumemura/patch-1 Fix username validation regex to correctly recognize hyphen (-)	2025-01-10 11:31:42 +07:00
Shobu UMEMURA	8fc518dba8	Fix username validation regex to correctly recognize hyphen (-) This pull request corrects the regular expression used for username validation to correctly recognize hyphens (-). Changes Made: Changed the regex pattern from ^([a-zA-Z0-9_.-@])+$ to ^([a-zA-Z0-9_.\-@])+$. Reason for Change: In the previous regex, the hyphen (-) within the character class was interpreted as a range operator, not as a literal character. This caused usernames with hyphens to be incorrectly marked as invalid. By escaping the hyphen (\-), the regex now correctly recognizes it as a literal character. This ensures that usernames containing hyphens are validated properly. Points of Verification: Confirmed that usernames containing hyphens are now correctly recognized and pass the validation. Verified that other characters (letters, numbers, underscores, dots, and at signs) are still being properly validated.	2024-09-28 17:57:02 +09:00

Author

SHA1

Message

Date

Konstantin Nezhbert

0ffb58cfe9

Merge 5dd44dad7f208f4e4035daacae33ff2bde7d70dc into 0680b4ff05a4e7b385416f3d87b5e0d234de8e7c

2025-01-17 18:12:07 +02:00

Dmitry Shurupov

0680b4ff05

Merge pull request #293 from ogumemura/patch-1

Fix username validation regex to correctly recognize hyphen (-)

2025-01-10 11:31:42 +07:00

Shobu UMEMURA

8fc518dba8

Fix username validation regex to correctly recognize hyphen (-)

This pull request corrects the regular expression used for username validation to correctly recognize hyphens (-).

Changes Made:
Changed the regex pattern from ^([a-zA-Z0-9_.-@])+$ to ^([a-zA-Z0-9_.\-@])+$.

Reason for Change:
In the previous regex, the hyphen (-) within the character class was interpreted as a range operator, not as a literal character. This caused usernames with hyphens to be incorrectly marked as invalid.
By escaping the hyphen (\-), the regex now correctly recognizes it as a literal character. This ensures that usernames containing hyphens are validated properly.

Points of Verification:
Confirmed that usernames containing hyphens are now correctly recognized and pass the validation.
Verified that other characters (letters, numbers, underscores, dots, and at signs) are still being properly validated.

2024-09-28 17:57:02 +09:00

1 changed files with 1 additions and 1 deletions

									
										2

main.go
									
											View File
											
				@ -34,7 +34,7 @@ import (

				)

				const (

					usernameRegexp       = `^([a-zA-Z0-9_.-@])+$`

					usernameRegexp       = `^([a-zA-Z0-9_.\-@])+$`

					passwordMinLength    = 6

					certsArchiveFileName = "certs.tar.gz"

					ccdArchiveFileName   = "ccd.tar.gz"

Compare commits

3 Commits

36b9ff2887 ... 0ffb58cfe9

2

main.go

View File

Compare commits

3 Commits 36b9ff2887 ... 0ffb58cfe9

2 main.go Unescape Escape View File

3 Commits

36b9ff2887 ... 0ffb58cfe9

2

main.go

View File